xiangfu0 commented on code in PR #19770:
URL: https://github.com/apache/pinot/pull/19770#discussion_r4237810597
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java:
##########
@@ -88,6 +89,56 @@ public void setRetentionTimeValue(String retentionTimeValue)
{
_retentionTimeValue = retentionTimeValue;
}
+ /// Returns the size retention limit, expressed as a positive size
understood by
+ /// [DataSizeUtils#toBytes(String)], for example `"100G"`.
+ ///
+ /// The limit sums compressed archive bytes for active, live completed
segments, counted once regardless of
+ /// replication. Live-segment lineage filtering excludes sources of
COMPLETED entries and destinations of other
+ /// entries to avoid counting shadow copies. OFFLINE APPEND and REALTIME
limits are enforced independently, including
+ /// hybrid tables. Each typed table expires its own oldest eligible data
without consulting the OFFLINE routing
+ /// time boundary. REALTIME size retention can therefore expire data newer
than that boundary; hybrid time
Review Comment:
Added the hybrid sizing guidance in 7c1945bc61: retain enough REALTIME data
beyond the routing boundary for RealtimeToOffline, and explain that deleting
this input can leave queries with no rows and no error. Scoped formatting,
checkstyle and license checks passed; the change is documentation only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
