xiangfu0 commented on code in PR #19795: URL: https://github.com/apache/pinot/pull/19795#discussion_r4241653913
########## LICENSE-binary: ########## @@ -280,7 +280,6 @@ com.squareup.wire:wire-runtime-jvm:5.1.0 com.squareup.wire:wire-schema-jvm:5.1.0 com.squareup:javapoet:1.13.0 com.squareup:kotlinpoet-jvm:1.18.1 -com.tdunning:t-digest:3.2 Review Comment: The new accumulator's cdf()/quantile()/K1 merge are structural ports of com.tdunning:t-digest (Apache-2.0, 'Licensed to Ted Dunning under one or more contributor license agreements'), including verbatim quirks like the single-centroid cdf branch and the negative-weight tail extrapolation. Removing the LICENSE-binary entry without adding an attribution notice for the derived source (in LICENSE, NOTICE, or the file headers) leaves the source release without the upstream copyright/license notice that ASF third-party licensing policy requires for copied Apache-2.0 code; a release vote could be blocked on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
