xiangfu0 commented on PR #19264: URL: https://github.com/apache/pinot/pull/19264#issuecomment-6135289860
Addressed the [follow-up review](https://github.com/apache/pinot/pull/19264#pullrequestreview-5496815672) in `801da9e880` and rebased onto current master (`fffc79c0cc1e`). - Added the largest-dictionary precheck, a fixed 1M-entry total scan cap, early rejection, and cancellation checks. - Dictionary unions now prefetch, acquire, and release scoped buffers, including the lazy S3 directory lifecycle. - Both EXPLAIN formats emit the marker only for opted-in queries, preserving `false` for rejected plans. - Corrected stale option comments and the PR description for the union proof and actual-use meter. Also adapted the BASE table to master's single-aggregation upsert API. Final JDK 25 validation passed: 81 core tests, eight focused integration cases, and all affected-module formatting/license/checkstyle checks. Independent review is clear. CI is rerunning on the pushed head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
