fx19880617 commented on a change in pull request #4874: Pinot ingestion job - 
Standalone
URL: https://github.com/apache/incubator-pinot/pull/4874#discussion_r352902878
 
 

 ##########
 File path: 
pinot-common/src/main/java/org/apache/pinot/filesystem/PinotFSFactory.java
 ##########
 @@ -43,6 +43,18 @@ private PinotFSFactory() {
 
   }
 
+  public static void register(String scheme, String fsClassName, Configuration 
configuration) {
 
 Review comment:
   This method extracts the logic of creating a FileSystem, Configuration is 
what used to init PinotFSFactory. And fsConfig.subset(key) is used as the  
Configuration to init internal PinotFS

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to