npawar commented on a change in pull request #4870: Add getResultColumnName API
to AggregationFunction to fetch sql compliant result name
URL: https://github.com/apache/incubator-pinot/pull/4870#discussion_r352908195
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/MinAggregationFunction.java
##########
@@ -40,6 +40,11 @@ public String getColumnName(String column) {
return AggregationFunctionType.MIN.getName() + "_" + column;
}
+ @Override
+ public String getResultColumnName(String column) {
Review comment:
Yes can be done. Moved the common logic to the default method implementation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
