Jackie-Jiang opened a new pull request, #19856: URL: https://github.com/apache/pinot/pull/19856
New `@Test` methods in `MultiNodesOfflineClusterIntegrationTest` are silently omitted from CI unless its four-method `@SelectMethod` allowlist is also updated. The class is excluded from normal lane discovery and runs through `MultiNodesOfflineSuite`. Select the class and use a suite-local TestNG method interceptor to run all tests declared by that class. Inherited offline tests remain covered by the existing offline suite, while inherited setup and teardown still run. Direct `-Dtest` execution is unchanged. The method allowlist originated in the XML suite from #19190 and was preserved during the native Surefire migration in #19633. Add lightweight regression coverage for automatic inclusion of additional declared tests, exclusion of inherited tests, disabled tests, and inherited fixture lifecycle. Keep the fixtures outside the test class to prevent TestNG from recursively discovering them in the outer run. Validation on JDK 25: - The integration-test module and its dependencies built successfully across all 64 reactor modules; `MultiNodesOfflineSuiteTest` passed both tests with no failures, errors, or skips. Compilation used warning and deprecation diagnostics; no warnings in changed files. - A separate JUnit Platform/TestNG engine smoke check executed only the two declared fixture scenarios and excluded the inherited scenario. - Affected-module Spotless, Checkstyle, license formatting, license validation, and `git diff --check` passed. The full multi-node cluster suite was not run locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
