noy-solvin commented on PR #19826: URL: https://github.com/apache/pinot/pull/19826#issuecomment-6158350844
Addressed review feedback on test hardening. Pre-captured the segment lock on the main test thread in `testReloadSegmentInterruptedDuringSemaphoreAcquire` (`BaseTableDataManagerTest.java`) prior to worker thread initialization, preventing weak-value cache eviction in `SegmentLocks` across GC and ensuring reliable post-interruption assertions. Production code in `BaseTableDataManager.java` remains untouched. Additional verification cycles completed successfully: * Static analysis, Checkstyle, Spotless, and License validations passed with 0 violations. * Dynamic unit tests passed (2/2). * Full regression test suite passed (3,726 tests passed, 0 failures, 0 regressions). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
