npawar commented on issue #4870: Add getResultColumnName API to AggregationFunction to fetch sql compliant result name URL: https://github.com/apache/incubator-pinot/pull/4870#issuecomment-560878561 > > This is good to have for now since we don't support aliasing. But this should be typically solved at a very high level using a mapping table. Let's make sure that this will not make it difficult to implement aliasing later. > > +1 to ^^. Would this be a throw away change when we support aliasing? Or will we just need a map at top level to do result column name translation? I don't think it will be a throw away change. The need for getting the resultName in this brackets format arose primarily because the SelectionSort has the column name in the brackets format vs aggregations have the name in the underscore format. Only the aggregation functions are converted to underscore format. Other functions (udfs), are in brackets format even today. In the absence of the new method, either the the order by clause will need to be rewritten to underscore format, or the column will have to be translated to underscore when applying order by (which is in 3 places).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
