xiangfu0 commented on code in PR #19739:
URL: https://github.com/apache/pinot/pull/19739#discussion_r4278268406
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1915,7 +1938,8 @@ && new
LLCSegmentName(segmentEntry.getKey()).getPartitionGroupId() == partitionI
break;
}
}
- if (previousConsumingSegment == null) {
+ // A segment created for an OFFLINE, ONLINE or new partition has no
previous CONSUMING segment
Review Comment:
Nit: the guard `(!createdByEarlierAttempt || replacesConsumingSegment)` is
correct but a bit dense to parse. A short inline note that it means "report
loss only for a brand-new commit, or a retried segment that was supposed to
replace a CONSUMING one" would help the next reader. No change needed if you'd
rather keep it terse.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1448,6 +1448,10 @@ public void ensureAllPartitionsConsuming(TableConfig
tableConfig, List<StreamCon
Preconditions.checkState(!_isStopping, "Segment manager is stopping");
String realtimeTableName = tableConfig.getTableName();
+ // The updater below runs again when the IdealState write fails (e.g. on a
version conflict), while the segment ZK
+ // metadata created by the failed attempt remains. Track the created
segments so that the next attempt still adds
+ // them to the IdealState.
+ Map<String, Boolean> newSegmentsCreated = new ConcurrentHashMap<>();
Review Comment:
Minor: the map value is a tri-state `Boolean` (absent / true = replaces a
CONSUMING segment / false = doesn't). It reads correctly given the Javadoc, but
a small enum or a tiny record would make the three states self-documenting at
the call sites. Totally optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
