thotashashank302 commented on code in PR #19821:
URL: https://github.com/apache/pinot/pull/19821#discussion_r4281379757
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FunctionOperand.java:
##########
@@ -106,6 +110,8 @@ public FunctionOperand(RexExpression.FunctionCall
functionCall, DataSchema dataS
_operands.add(TransformOperandFactory.getTransformOperand(operand,
dataSchema));
}
_reusableOperandHolder = new Object[numOperands];
+ _cacheable = functionInfo.getVolatility() != FunctionVolatility.VOLATILE
+ && _operands.stream().allMatch(LiteralOperand.class::isInstance);
Review Comment:
Yes, caching zero-argument immutable/stable calls was deliberate, which is
why operandCacheZeroArgs was added to cover it. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
