yashmayya commented on PR #19788: URL: https://github.com/apache/pinot/pull/19788#issuecomment-6200059977
@xiangfu0 Thanks for the review. Added two null cases in ff10534427. `CAST(NULL AS INTERVAL MONTH)` fails before this rule, in validation (`BytesCastVisitor`, an unrelated issue that was already there). Calcite also folds most other null forms before this rule runs. So the tests use a Pinot function that returns null: - `fromDateTime(CAST(NULL AS VARCHAR), 'yyyy-MM-dd') + INTERVAL '1' MONTH` (null datetime) - `TIMESTAMP '2019-01-01 00:00:00' + INTERVAL '1' MONTH * toEpochDays(fromDateTime(CAST(NULL AS VARCHAR), 'yyyy-MM-dd'))` (null interval) I checked that both cases reach the null branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
