xiangfu0 commented on code in PR #19878:
URL: https://github.com/apache/pinot/pull/19878#discussion_r4289838247
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -650,6 +650,9 @@ public boolean equals(Object o) {
return false;
}
InstanceStateMaps that = (InstanceStateMaps) o;
+ // NOTE: Map.equals() ignores the iteration order, so maps with the same
entries in a different order share one
+ // canonical instance. This is correct because every candidate
list is built in the order of
Review Comment:
Small wording nit: "share one canonical instance" reads a bit ambiguously
here, since "instance" is also the domain term for a server node. Maybe say
"share one canonical InstanceStateMaps" to make it clear you mean the cached
object, not a server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
