xiangfu0 opened a new pull request, #19933: URL: https://github.com/apache/pinot/pull/19933
Re-enable testGroupByWithOptimization by quoting the intended "value" column. With BABEL syntax, unquoted value + 10 parses as VALUES(ROW(10)), so the old fixture never exercised the intended column arithmetic. Preserve every assertion for the arithmetic rewrite and GROUP BY category. No production optimizer change is needed. Validation was run on the combined test-audit checkout at base `9de9e0115545`; this PR contains only the independent item above, with identical changed files and unchanged production dependencies. - AggregationOptimizerTest: all 29 cases passed, including the restored method. A probe against freshly compiled sources reproduced the old SUM(VALUES(ROW(10))) expression and confirmed the corrected ADD(SUM(value), MULT(10, COUNT(value))) rewrite preserves grouping. - Affected-module `spotless:apply`, `license:format`, `checkstyle:check`, and `license:check` passed. - Production/test compilation passed with `maven.compiler.showDeprecation=true` and `maven.compiler.showWarnings=true`; no compiler warnings on added lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
