kishoreg opened a new issue #4881: Pinot Ingestion refactor - follow up tasks URL: https://github.com/apache/incubator-pinot/issues/4881 Kishore - [ ] Remove utils from pinot-spi - [x] Remove dependency on pinot-core from record-reader-test (mostly because of CompositeTransformer) From Subbu #4874 - [ ] (1) Please make the variable declaration private in the new classes introduced (basically, in all the classes that just support get/set on a bunch of variables) - [ ] (2) Consider moving the comments to the setter (Not sure if we see users invoking the setter, or all this happening only through yaml files. - [ ] (3) Please look through the log lines to include as much detail as possible. I am not sure if segments for multiple tables can be constructed in one go, but it is always good to print the table name in the logs (something we learned so far in other parts of the code) when things are running at scale and we only have some grepped out log lines that someone posts asking for help. I tried to look as much as I could, but another pair of eyes cannot hurt. - [ ] (4) Provide as many examples as possible in the javadocs (e.g. for className, just add an example class name) - [ ] (5) I would add a lot of comments in the yaml files, so that they are self-explanatory for other possible ways of writing them. You can decide what makes most sense here, and make a judgement call on the volume of comments. Are you also going to change the doc files or is that a separate PR? (I am fine with another PR) - [ ] Did you make sure that we exit with the right (informative error message) when things don't work? (as it often happens for the first-timer). Please verify that the exception/messages look fine in the following cases (It is totally worth doing these once before committing): (a) controller not running (b) table config not found (c) schema not found (d) input files have zero rows (not necessarily zero-sized rows). (d) Input files do not exist in the path mentioned (e) Cannot create temporary tar files (either due to permission, or otherwise) (f) Quota exceeded on the controller (g) Number of retries exceeded
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
