Jackie-Jiang commented on code in PR #19973:
URL: https://github.com/apache/pinot/pull/19973#discussion_r4329116639
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotRuleUtils.java:
##########
@@ -162,16 +166,14 @@ public static String extractFunctionName(RexCall
function) {
/// Note this is a predicate that callers must apply; it is not enforced
globally. Only [PinotFilterJoinRule]
/// consults it today, so other rules that relocate expressions can still
move volatile ones.
public static boolean isRelocatable(RexNode node) {
- if (!RexUtil.isDeterministic(node)) {
- return false;
- }
try {
node.accept(new RexVisitorImpl<Void>(true) {
@Override
public Void visitCall(RexCall call) {
SqlOperator operator = call.getOperator();
- if (operator.isDynamicFunction()
- || (operator instanceof PinotSqlFunction && ((PinotSqlFunction)
operator).isVolatile())) {
+ if (operator != PinotOperatorTable.ARRAY_TO_MV &&
(!operator.isDeterministic()
Review Comment:
Consider reformatting this. The current line breaks are misleading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
