Jackie-Jiang opened a new pull request, #19984:
URL: https://github.com/apache/pinot/pull/19984
## Summary
`FunctionRegistry` canonicalizes function names by removing underscores and
lowercasing them, so a snake_case alias such as `ip_family` maps to the same
canonical name as `ipFamily`. Listing both in `@ScalarFunction(names = ...)`
registers nothing extra; it only makes `FunctionRegistry` log a `Duplicate
names` warning for each function on startup.
This removes the redundant aliases from 12 functions:
- `IpAddressFunctions`: `ipFamily`, `ipMaskLen`, `ipNetmask`, `ipHostmask`,
`isPrivateIp`
- `StringFunctions`: `substringIndex`, `octetLength`, `bitLength`,
`charLength`, `regexpCount`, `regexpSubstr`
- `ArithmeticFunctions`: `widthBucket`
Where the only remaining name equals the method name, the annotation becomes
a bare `@ScalarFunction`. `charLength` keeps `names = {"charLength",
"characterLength"}`.
Queries are unaffected, since `ip_family(...)` still resolves through
canonicalization. The `Duplicate names` warning in `FunctionRegistry` stays to
catch real duplicates.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
