kishoreg opened a new pull request #4883: Simplifying interface related to StreamLevelConsumer URL: https://github.com/apache/incubator-pinot/pull/4883 I tried to move the real-time interfaces to pinot-spi but saw that we depend on InstanceMetadata and ServerMetrics for stream level consumer. This dependency was needed to get the groupId and log some metrics. I moved the logging to common Pinot HLC Consumer and passed groupId as part of the interface. OLD ` public abstract StreamLevelConsumer createStreamLevelConsumer(String clientId, String tableName, Schema schema, InstanceMetadata instanceMetadata, ServerMetrics serverMetrics);` NEW ` public abstract StreamLevelConsumer createStreamLevelConsumer(String clientId, String tableName, Schema schema, String groupId);`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
