siddharthteotia commented on a change in pull request #4877: Results in
ResultTable if responseFormat=sql
URL: https://github.com/apache/incubator-pinot/pull/4877#discussion_r353485939
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
##########
@@ -218,59 +253,47 @@ private IndexedTable getIndexedTable(GroupBy groupBy,
List<AggregationInfo> aggr
* There will be 1 aggregation result per aggregation. The group by keys
will be the same across all aggregations
* @param brokerResponseNative broker response
* @param dataSchema data schema
- * @param aggregationInfos aggregations info
- * @param groupBy group by info
- * @param orderBy order by info
* @param dataTables Collection of data tables
*/
- private void setPQLGroupByOrderByResults(BrokerResponseNative
brokerResponseNative, DataSchema dataSchema,
- List<AggregationInfo> aggregationInfos, GroupBy groupBy,
List<SelectionSort> orderBy,
+ private void setSQLGroupByInAggregationResults(BrokerResponseNative
brokerResponseNative, DataSchema dataSchema,
Review comment:
A comment here would be helpful for context -- something like this is needed
for users that are using SQL GROUP BY ORDER BY but for backward compatibility,
the results are still sent in old format. I believe this is what this function
is doing. Right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
