mcvsubbu commented on a change in pull request #4874: Pinot ingestion job -
Standalone
URL: https://github.com/apache/incubator-pinot/pull/4874#discussion_r353506762
##########
File path:
pinot-batch-ingestion/pinot-standalone/src/main/java/org/apache/pinot/ingestion/common/PushJobSpec.java
##########
@@ -52,23 +57,36 @@ public String getSegmentUriSuffix() {
return _segmentUriSuffix;
}
+ /**
+ * Used in SegmentUriPushJobRunner, which is used to composite the segment
uri to send to pinot controller.
+ * The URI sends to controller is in the format
${segmentUriPrefix}${segmentPath}${segmentUriSuffix}
+ * @param segmentUriSuffix
+ */
public void setSegmentUriSuffix(String segmentUriSuffix) {
_segmentUriSuffix = segmentUriSuffix;
}
- public int getRetryCount() {
- return _retryCount;
+ public int getPushAttempts() {
+ return _pushAttempts;
}
- public void setRetryCount(int retryCount) {
- _retryCount = retryCount;
+ /**
+ * number of attempts for push job, default is 1, which means no retry.
+ * @param pushAttempts
+ */
+ public void setPushAttempts(int pushAttempts) {
+ _pushAttempts = pushAttempts;
}
- public long getRetryWaitMs() {
- return _retryWaitMs;
+ public long getPushRetryTimeinMillis() {
+ return _pushRetryTimeinMillis;
}
- public void setRetryWaitMs(long retryWaitMs) {
- _retryWaitMs = retryWaitMs;
+ /**
+ * retry wait Ms, default to 1 second.
+ * @param pushRetryTimeinMillis
+ */
+ public void setPushRetryTimeinMillis(long pushRetryTimeinMillis) {
Review comment:
suggest: pushRetryIntervalMillis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
