npawar commented on a change in pull request #4877: Results in ResultTable if
responseFormat=sql
URL: https://github.com/apache/incubator-pinot/pull/4877#discussion_r353523619
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorService.java
##########
@@ -179,4 +180,31 @@ public SelectionResults
renderSelectionResultsWithOrdering(boolean preserveType)
return new SelectionResults(_selectionColumns, rowsInSelectionResults);
}
+
+ /**
+ * Render the selection rows to a {@link ResultTable} object for selection
queries with
+ * <code>ORDER BY</code>. (Broker side)
+ * <p>{@link ResultTable} object will be used to build the broker response.
+ * <p>Should be called after method "reduceWithOrdering()".
+ *
+ * @return {@link SelectionResults} object results.
+ */
+ public ResultTable renderResultTableWithOrdering() {
+ LinkedList<Object[]> rowsInSelectionResults = new LinkedList<>();
Review comment:
It's a LinkedList, implementation doesn't require or permit initial size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
