codecov-io commented on issue #4882: Failure to recover after segment reload failure does not release segment lock URL: https://github.com/apache/incubator-pinot/pull/4882#issuecomment-561461079 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4882?src=pr&el=h1) Report > Merging [#4882](https://codecov.io/gh/apache/incubator-pinot/pull/4882?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/82359d0fa78cf674516139f577e37f3422aaef60?src=pr&el=desc) will **increase** coverage by `19.83%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4882?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4882 +/- ## ============================================ + Coverage 36.76% 56.6% +19.83% - Complexity 0 50 +50 ============================================ Files 1174 1175 +1 Lines 62574 62621 +47 Branches 9178 9181 +3 ============================================ + Hits 23005 35444 +12439 + Misses 37497 24539 -12958 - Partials 2072 2638 +566 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4882?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...server/starter/helix/HelixInstanceDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXIuamF2YQ==) | `82.53% <0%> (-4.97%)` | `0 <0> (ø)` | | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | | | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `60.31% <0%> (-3.18%)` | `0% <0%> (ø)` | | | [...ot/common/protocols/SegmentCompletionProtocol.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcHJvdG9jb2xzL1NlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2wuamF2YQ==) | `94.05% <0%> (-0.55%)` | `0% <0%> (ø)` | | | [...pache/pinot/parquet/data/readers/ParquetUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3QtcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGFycXVldC9kYXRhL3JlYWRlcnMvUGFycXVldFV0aWxzLmphdmE=) | | | | | [...ache/pinot/core/data/readers/JSONRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvSlNPTlJlY29yZFJlYWRlci5qYXZh) | | | | | [...pache/pinot/core/data/readers/CSVRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvQ1NWUmVjb3JkUmVhZGVyLmphdmE=) | | | | | [...che/pinot/core/data/readers/RecordReaderUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUmVjb3JkUmVhZGVyVXRpbHMuamF2YQ==) | | | | | [...he/pinot/core/data/readers/ThriftRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvVGhyaWZ0UmVjb3JkUmVhZGVyLmphdmE=) | | | | | [...ain/java/org/apache/pinot/core/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0F2cm9VdGlscy5qYXZh) | | | | | ... and [581 more](https://codecov.io/gh/apache/incubator-pinot/pull/4882/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4882?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4882?src=pr&el=footer). Last update [82359d0...4cf9ded](https://codecov.io/gh/apache/incubator-pinot/pull/4882?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
