xiangfu0 commented on code in PR #20019:
URL: https://github.com/apache/pinot/pull/20019#discussion_r4364633101
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -2491,13 +2486,32 @@ public static boolean
isTableTypeInconsistentDuringConsumption(@Nullable TableCo
|| upsertConfig.getOutOfOrderRecordColumn() != null);
}
- // enum of all the skip-able validation types.
- // ACTIVE_TASKS is retained for backward compatibility: it is still accepted
as a validationTypesToSkip value so
- // existing clients do not break, but it is no longer consumed by any
production path. Active-task validation runs
- // only on the create/update path (see
PinotTableRestletResource.tableTasksValidation, gated by ignoreActiveTasks),
- // not on the validate/tune preflight endpoints, so passing ACTIVE_TASKS
there is a no-op.
+ /// Validation types that can be skipped through the `validationTypesToSkip`
parameter. A type is skipped when the
+ /// types to skip contain it or `ALL`, see [#isSkipped].
public enum ValidationType {
Review Comment:
Dropping `ACTIVE_TASKS` from the enum means it now gets rejected with a 400
instead of being silently accepted as a no-op. I think that's a reasonable
cleanup, but since it used to be explicitly kept "so existing clients do not
break," any caller still passing `ACTIVE_TASKS` would start failing. Worth a
quick mention in the release notes so folks aren't surprised — not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
