xiangfu0 commented on code in PR #19998:
URL: https://github.com/apache/pinot/pull/19998#discussion_r4367065501
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -52,13 +51,16 @@
import org.apache.pinot.spi.data.FieldSpec.DataType;
import org.apache.pinot.spi.data.OpenStructNaming;
import org.apache.pinot.spi.data.Schema;
+import org.apache.pinot.spi.env.PinotConfiguration;
import org.apache.pinot.spi.utils.JsonUtils;
import org.apache.pinot.spi.utils.ReadMode;
import org.apache.pinot.spi.utils.TimestampIndexUtils;
/// Index loading config with shared table-level state and segment-local
mutable overrides.
public class IndexLoadingConfig {
+ /// Instance config key, relative to `pinot.server.instance`, for reverting
to eager serving metadata.
Review Comment:
Tiny doc nit: this reads like the key disables mapped metadata, but it is
named `..._ENABLED`, defaults to false, and setting it true turns the feature
on. Could we reword to something like "enables mapped (file-backed) serving
metadata; defaults to off" so the opt-in direction is clear?
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -52,13 +51,16 @@
import org.apache.pinot.spi.data.FieldSpec.DataType;
import org.apache.pinot.spi.data.OpenStructNaming;
import org.apache.pinot.spi.data.Schema;
+import org.apache.pinot.spi.env.PinotConfiguration;
import org.apache.pinot.spi.utils.JsonUtils;
import org.apache.pinot.spi.utils.ReadMode;
import org.apache.pinot.spi.utils.TimestampIndexUtils;
/// Index loading config with shared table-level state and segment-local
mutable overrides.
public class IndexLoadingConfig {
+ /// Instance config key, relative to `pinot.server.instance`, for reverting
to eager serving metadata.
Review Comment:
Tiny doc nit: this reads like the key disables mapped metadata, but it is
named `..._ENABLED`, defaults to false, and setting it true turns the feature
on. Could we reword to something like "enables mapped (file-backed) serving
metadata; defaults to off" so the opt-in direction is clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
