Jackie-Jiang commented on code in PR #20057:
URL: https://github.com/apache/pinot/pull/20057#discussion_r4381344184
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -394,6 +394,9 @@ public static long getRandomInitialDelayInSeconds() {
// the controller as ready. When enabled,
controller.resource.utilization.checker.initial.delay is set to 0.
public static final String
RESOURCE_UTILIZATION_CHECKER_COLLECT_USAGE_AT_STARTUP =
"controller.resource.utilization.checker.collect.usage.at.startup";
+ /// @deprecated Use `segmentsConfig.enableHybridTableRetentionStrategy` in
the table config instead (see
+ ///
[org.apache.pinot.spi.config.table.SegmentsValidationAndRetentionConfig#getEnableHybridTableRetentionStrategy()]).
+ @Deprecated(since = "1.6.0", forRemoval = true)
Review Comment:
Don't deprecate this config. We want to allow cluster config to set the
default if it is not configured at table level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
