xiangfu0 commented on PR #20035: URL: https://github.com/apache/pinot/pull/20035#issuecomment-6430899028
@Jackie-Jiang, plan-level rewriting can also preserve correctness during partial reloads. This PR rewrites once before fetch planning in both instance paths, using only derived columns present on every selected segment. Mixed-index sets retain the original expression, and later segment calls are no-ops. Grouping by available override columns would let indexed subsets retain the optimization, but needs isolated mutable query/aggregation contexts per group and compatible combine layouts. I kept that optimization separate from this correctness fix. The existing regression covers fully indexed and mixed-index sets in normal and streaming planning. I documented the ownership contract and the internal rebuild hook in af7d522ed8. All 28 focused tests and scoped formatting/license/Checkstyle checks passed after rebasing onto current master. [Detailed inline response](https://github.com/apache/pinot/pull/20035#discussion_r4384033804). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
