raghavyadav01 commented on code in PR #20039:
URL: https://github.com/apache/pinot/pull/20039#discussion_r4392135535
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -542,6 +544,8 @@ public synchronized Map<String, TaskStatusSummary>
getTableTaskStatusSummary(Str
if (partition != null) {
state = jobContext.getPartitionState(partition);
executionStartTime = jobContext.getPartitionStartTime(partition);
+ lastProgressTime =
+ Math.max(lastProgressTime, Math.max(executionStartTime,
jobContext.getPartitionFinishTime(partition)));
Review Comment:
The gauge measures the job's queue, not each table: all subtasks in a job
share one Helix queue, so if table1's subtasks are starting and finishing,
table2's waiting ones are moving up too. Per-table tracking would flag a table
that is only waiting its turn in a queue that's draining, the false alarm this
PR removes. A table whose own subtask hangs while running is caught by the
running-time gauge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
