raghavyadav01 commented on code in PR #19891:
URL: https://github.com/apache/pinot/pull/19891#discussion_r4392884946
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java:
##########
@@ -216,6 +216,21 @@ public class BrokerMeter implements AbstractMetrics.Meter {
public static final BrokerMeter ROUTING_TABLE_UPDATE_FAILURE =
create("ROUTING_TABLE_UPDATE_FAILURE", "failures", false);
+ /// Number of queries that touched a segment eligible for fail-open routing
(unavailable, but with candidate servers
+ /// that are all disabled). Counted once per query per physical table, even
if the query routes that table more than
+ /// once (e.g. a multi-stage self-join); concurrent queries routing the same
table in between can rarely recount it.
+ ///
+ /// This metric is global.
+ public static final BrokerMeter FAIL_OPEN_ELIGIBLE_REQUESTS =
Review Comment:
FAIL_OPEN_ELIGIBLE_REQUESTS is global, so it tells us fail-open would help
but not for which tables. Since the point is deciding where to turn it on,
could this one be per table like the segments meter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
