anuragrai16 commented on PR #19529:
URL: https://github.com/apache/pinot/pull/19529#issuecomment-6464806831
Thanks @gortiz , agree with the scope reduction for now. Updated the PR to
keep only the runtime API. Agreed on not persisting the FQCN since it has its
own problem. If we need durable per-segment tracking later, I'll think of how
to design it around a decoder id. I'll also treat any fleet-wide metric as a
separate follow-up, behind a flag that's off by default.
- **Removed**: the gauge, the setValueOfTableGauge overload, the JMX
rules, and the custom.decoder.class metadata along with the converter overload.
That also takes out the ZK side effect you found, which wasn't intentional.
- **Kept**: decoderClassName on the DTOs and the getValueDecoder() SPI
default. The value is computed per request and nothing is persisted.
- **Compatibility**: the old DTO constructors are back and delegate with
null, and the new ones carry @JsonCreator.
There are tests for the legacy constructors, JSON round-tripping, and
payloads from older servers. Javadoc is switched to the markdown style.
Can you do a re-review please ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
