mayankshriv commented on issue #4885: Encrypt segments during segment creation [1] URL: https://github.com/apache/incubator-pinot/pull/4885#issuecomment-561868783 The issue is that SegmentIndexCreationDriverImpl stops at creating v3 segment dir. Then we have separate pieces of code floating around that tar and gzip the folder, and once we start encrypting, each of those segment generation paths will have to encrypt as well. The main motivation of this PR is to consolidate segment v3 generation + tar.gz + encryption all at one place, so all callers can leverage it. Also, to point out, the idea is to encrypt post .tar.gz creation, purely because it is simpler to deal with encryption/decryption at a single file level.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
