Jackie-Jiang commented on code in PR #20074:
URL: https://github.com/apache/pinot/pull/20074#discussion_r4418065219
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultistageAggregationExecutor.java:
##########
@@ -182,8 +182,7 @@ private void processMergeFinalResults(MseBlock.Data block) {
Object[] finalResults =
AggregateOperator.getIntermediateResults(aggFunction, block);
for (Object finalResult : finalResults) {
_mergeResultHolder[i] =
- AggregationFunctionUtils.mergeFinalResult(aggFunction,
(Comparable) _mergeResultHolder[i],
- (Comparable) finalResult);
+ AggregationFunctionUtils.mergeFinalResult(aggFunction,
_mergeResultHolder[i], finalResult);
Review Comment:
Thanks, I noted it under "Follow-up" in the description. Their final results
are not more compact than their intermediate results, so returning final
results gains little for these functions. A separate PR will add
`mergeFinalResult` to them and to the other functions whose final results can
be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
