xiangfu0 commented on PR #18668: URL: https://github.com/apache/pinot/pull/18668#issuecomment-6513498123
Fixed the Unit Test Set 2 failure in 796dedc132. TestNG selected its Iterable overload for JsonNode assertions, making equal property objects depend on iteration order and scalar codec comparisons vacuous. The three affected assertions now select structural JsonNode equality. Validation: all 108 tests in TableConfigsRestletResourceTest and TableConfigUtilsTest passed, as did scoped Spotless, license, Checkstyle and warning-enabled compilation. A deterministic reproduction confirms reordered equal objects pass and different codec values fail. Independent review approved the test-only change. The prior head passed the other 12 checks; CI is restarting on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
