kpatel006 commented on code in PR #19892:
URL: https://github.com/apache/pinot/pull/19892#discussion_r4420354088
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -231,8 +233,14 @@ public void init(PinotConfiguration brokerConf)
// Remove all white-spaces from the list of zkServers (if any).
_zkServers =
brokerConf.getProperty(Helix.CONFIG_OF_ZOOKEEPER_SERVER).replaceAll("\\s+", "");
_clusterName = brokerConf.getProperty(Helix.CONFIG_OF_CLUSTER_NAME);
+ // Capture the instance-level fallback before applying the cluster config
overlay.
+ boolean brokerConfiguredFailOpenEnabled =
brokerConf.getProperty(Broker.CONFIG_OF_ENABLE_FAIL_OPEN,
+ Broker.DEFAULT_ENABLE_FAIL_OPEN);
ServiceStartableUtils.applyClusterConfig(_brokerConf, _zkServers,
_clusterName, ServiceRole.BROKER);
applyCustomConfigs(brokerConf);
+ boolean startupFailOpenEnabled =
brokerConf.getProperty(Broker.CONFIG_OF_ENABLE_FAIL_OPEN,
Review Comment:
Cluster value wins here was intentional because fail-open is making routing
changes that should be consistent across a cluster's brokers. I don't think
there is any reason to have a broker with it enabled and another disabled, but
that option does exist if cluster config is removed.
> redundant `startupFailOpenEnabled`
I agree will update this.
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -231,8 +233,14 @@ public void init(PinotConfiguration brokerConf)
// Remove all white-spaces from the list of zkServers (if any).
_zkServers =
brokerConf.getProperty(Helix.CONFIG_OF_ZOOKEEPER_SERVER).replaceAll("\\s+", "");
_clusterName = brokerConf.getProperty(Helix.CONFIG_OF_CLUSTER_NAME);
+ // Capture the instance-level fallback before applying the cluster config
overlay.
+ boolean brokerConfiguredFailOpenEnabled =
brokerConf.getProperty(Broker.CONFIG_OF_ENABLE_FAIL_OPEN,
+ Broker.DEFAULT_ENABLE_FAIL_OPEN);
ServiceStartableUtils.applyClusterConfig(_brokerConf, _zkServers,
_clusterName, ServiceRole.BROKER);
applyCustomConfigs(brokerConf);
+ boolean startupFailOpenEnabled =
brokerConf.getProperty(Broker.CONFIG_OF_ENABLE_FAIL_OPEN,
Review Comment:
Cluster value wins here was intentional because fail-open is making routing
changes that should be consistent across a cluster's brokers. I don't think
there is any reason to have a broker with it enabled and another disabled, but
that option does exist if cluster config is removed.
> redundant `startupFailOpenEnabled`
I agree will update this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
