chenboat opened a new pull request #4889: Use jar-no-fork as the goal instead of jar for maven-source-plugin URL: https://github.com/apache/incubator-pinot/pull/4889 The current plugin has a few issues: (1) it does not list the version as recommend by Maven (minor issue though). (2) Using jar as the goal instead of the default jar-no-fork which causes our internal release failure in Uber. As explained in the following links: https://maven.apache.org/plugins/maven-source-plugin/jar-no-fork-mojo.html https://stackoverflow.com/questions/10567551/difference-between-maven-source-plugin-jar-and-jar-no-fork-goal jar-no-fork is more suitable to attach to Maven build cycle and using jar as a goal will cause will re-run all of the goals bound to generate-sources and its predecessors. I assume more use cases of this plugin is to build and release and thus jar-no-fork. More important, the current goal of jar also caused two goals for the attach-sources plugin. That means the source jars will be uploaded twice to our artifactory in Uber -- which results in release failure due to file overwrite issues. I am not sure how LinkedIn solve this issue. >> mvn -Prelease-profile help:effective-pom ---------------------------------------- <plugin> <artifactId>maven-source-plugin</artifactId> <version>3.0.1</version> <executions> <execution> <id>attach-sources</id> <goals> <goal>jar-no-fork</goal> <goal>jar</goal> </goals> </execution> </executions> <inherited>true</inherited> </plugin>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
