xiangfu0 commented on code in PR #20084:
URL: https://github.com/apache/pinot/pull/20084#discussion_r4425840953
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TenantRebalanceIntegrationTest.java:
##########
@@ -22,19 +22,87 @@
import javax.annotation.Nullable;
import org.apache.pinot.common.restlet.resources.TenantRebalanceResult;
import
org.apache.pinot.controller.helix.core.rebalance.tenant.TenantRebalanceConfig;
+import
org.apache.pinot.integration.tests.SharedHybridClusterIntegrationTestSuite.HybridScenarioLease;
+import
org.apache.pinot.integration.tests.SharedHybridClusterIntegrationTestSuite.SharedHybridSuiteLease;
+import org.apache.pinot.spi.config.table.TableType;
import org.apache.pinot.spi.utils.JsonUtils;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertNotNull;
import static org.testng.Assert.assertTrue;
-public class TenantRebalanceIntegrationTest extends
BaseHybridClusterIntegrationTest {
+/// Verifies tenant rebalance request handling using isolated tables in the
shared hybrid cluster.
+/// Scenarios run sequentially; a directly selected class owns a temporary
cluster through the same lease.
+public class TenantRebalanceIntegrationTest {
+ private static final String TABLE_NAME = "mytableTenantRebalance";
+ private static final String TOPIC_NAME = "TenantRebalanceIntegrationTest";
+
+ private SharedHybridSuiteLease _suiteLease;
+ private SharedHybridClusterIntegrationTestSuite _owner;
+ private HybridScenarioLease _scenario;
+
+ @BeforeClass(alwaysRun = true)
+ public void setUp()
+ throws Throwable {
+ try {
+ _suiteLease =
SharedHybridClusterIntegrationTestSuite.acquireSharedSuite();
+ _owner = _suiteLease.getOwner();
+ // Preserve the original fixture's offline-first teardown to exercise
both hybrid table removal orders.
Review Comment:
Nit: "the original fixture" will mean nothing once this PR has merged. Maybe
say what the code does now, e.g. `// Drop OFFLINE before REALTIME; other suite
scenarios drop REALTIME first, so both removal orders are covered.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
