shuturmurgh commented on code in PR #19450:
URL: https://github.com/apache/pinot/pull/19450#discussion_r4432660720
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -484,6 +484,7 @@ protected void
replaceSegmentIfCrcMismatch(SegmentDataManager segmentDataManager
_logger.info("Replacing segment: {} because its CRC has changed from: {}
to: {}", segmentName,
localMetadata.getCrc(), zkMetadata.getCrc());
downloadAndLoadSegment(zkMetadata, indexLoadingConfig);
+ _serverMetrics.addMeteredTableValue(_tableNameWithType,
ServerMeter.SEGMENT_REPLACED_DUE_TO_CRC_MISMATCH, 1);
Review Comment:
With `SEGMENT_BUILD_WITH_CRC_MISMATCH` scoped to local realtime builds,
reload/replace increments in `BaseTableDataManager` are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
