xiangfu0 commented on code in PR #20082: URL: https://github.com/apache/pinot/pull/20082#discussion_r4439092575
########## pinot-spi/src/main/java/org/apache/pinot/spi/ingestion/error/IngestionSourceErrorReporter.java: ########## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.ingestion.error; + +import java.util.function.Consumer; + + +public final class IngestionSourceErrorReporter { Review Comment: Minor: after the comment removals, none of the new main classes in this PR has class-level docs. That includes this public SPI and `IngestionSourceErrorClassifier`. This class's contract isn't visible from its signature: the listener is per thread, `report` never throws, and a plugin should report only failures it won't retry itself. CLAUDE.md asks new classes to document behavior and thread safety. A short class doc on the public SPI types would be enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
