prajwal-jadhav01 commented on code in PR #20121:
URL: https://github.com/apache/pinot/pull/20121#discussion_r4445534475
##########
pinot-connectors/pinot-flink-connector/src/main/java/org/apache/pinot/connector/flink/sink/PinotSink.java:
##########
@@ -137,6 +140,21 @@ static TableConfig prepareTableConfigForSink(TableConfig
tableConfig, String con
return tableConfig;
}
+ /// Builds an [AuthProvider] from the `authToken` in the table's batch
config, or returns null if none is set.
Review Comment:
Done. I added the note to the createAuthProvider doc and an "Authentication"
section to the connector README. While writing the README example I noticed
that if the table config has no batch config yet, there's no clean way for
users to add the token, because the 4-arg constructor builds a fresh batch
config without it. So I took your earlier suggestion and added PinotSink(...,
controllerBaseUrl, authToken), which puts the token into the in-memory batch
config in all cases. The README example now uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
