xiangfu0 opened a new pull request, #20145: URL: https://github.com/apache/pinot/pull/20145
S3 listing metadata can include fractional seconds, while the HEAD Last-Modified header reports whole seconds. Comparing those values directly can treat the same object as newer and cause a caller to reprocess it. Add a default `PinotFS.compareLastModifiedTimes` method for comparing values from listing and direct metadata lookups. S3 compares at whole-second precision and other implementations inherit the existing millisecond comparison. `NoClosePinotFS` forwards the comparison to its delegate. Callers that use raw timestamps for retention or display continue to get the original values. Validation: 16 `S3PinotFSPaginatedListTest` cases passed on JDK 25. Scoped Spotless, Checkstyle, and license checks passed for `pinot-spi` and `pinot-s3`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
