gortiz commented on PR #20058: URL: https://github.com/apache/pinot/pull/20058#issuecomment-6628001819
Thanks for the reviews! I pushed 88acdd6af0, which follows @Jackie-Jiang's design points: - The tracker no longer reads ZooKeeper or registers a Helix listener. The broker routing manager feeds it the instance configs that it already reads, so a broker adds no reads and no watches. `RoutingManager.getMinServerCapabilityRevision` exposes the result. - Brokers advertise their capabilities too. - Extensions can define their own capabilities. Readers track every entry of the map. - The Javadoc now says that a name is never reused and that the guard cannot detect a rollback between builds with the same version string. I also updated the description: [apache/pinot#20061](https://github.com/apache/pinot/pull/20061) no longer depends on this PR, because it uses the `auto` fallback instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
