xiangfu0 commented on code in PR #20152:
URL: https://github.com/apache/pinot/pull/20152#discussion_r4472087020
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -487,7 +488,8 @@ protected void doPreloadSegment(ImmutableSegmentImpl
segment) {
_logger.info("Preloading segment: {}, current primary key count: {}",
segmentName, getNumPrimaryKeys());
long startTimeMs = System.currentTimeMillis();
- MutableRoaringBitmap validDocIds =
segment.loadDocIdsFromSnapshot(V1Constants.VALID_DOC_IDS_SNAPSHOT_FILE_NAME);
+ MutableRoaringBitmap validDocIds = segment.loadDocIdsFromSnapshot(
Review Comment:
Nit: this bitmap is also loaded via `loadDocIdsFromSnapshot` and passed to
`skipPreloadSegmentOutOfTTL(segment, validDocIdsOnDiskBitmap)`, but it keeps
the name `validDocIds`. The PR description says such bitmaps get renamed.
Should this be `validDocIdsOnDiskBitmap` too, for consistency?
_AI-generated review via IntentLab · Model: Claude Opus 5.5
(claude-opus-5-5)_
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -1349,7 +1349,8 @@ public void reloadSegment(String segmentName,
IndexLoadingConfig indexLoadingCon
indexDir = downloadSegment(zkMetadata);
if (backupValidDocIdsSnapshotFile != null &&
backupValidDocIdsSnapshotFile.exists()) {
FileUtils.copyFile(backupValidDocIdsSnapshotFile, new File(
- SegmentDirectoryPaths.findSegmentDirectory(indexDir),
V1Constants.VALID_DOC_IDS_SNAPSHOT_FILE_NAME));
+ SegmentDirectoryPaths.findSegmentDirectory(indexDir),
+ V1Constants.VALID_DOC_IDS_ON_DISK_BITMAP_FILE_NAME));
Review Comment:
Nit: this argument is indented 4 more spaces than its sibling
`SegmentDirectoryPaths.findSegmentDirectory(indexDir),` on the line above. Both
are arguments to the same `new File(...)`, so they should line up.
_AI-generated review via IntentLab · Model: Claude Opus 5.5
(claude-opus-5-5)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
