raghavyadav01 commented on code in PR #20072:
URL: https://github.com/apache/pinot/pull/20072#discussion_r4463466770
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/vector/HnswVectorIndexCreator.java:
##########
@@ -100,24 +124,94 @@ public void add(Object[] values, @Nullable int[] dictIds)
{
@Override
public void add(float[] document) {
+ if (_bufferedVectors != null) {
+ // Callers may reuse the array for the next row
+ _bufferedVectors.add(document.clone());
Review Comment:
Documented the heap cost on the field and in the PR description. A
byte-based limit is a good idea; I'd rather do it as a follow-up once we have
numbers from wider dims.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
