manakbisht opened a new pull request, #20182:
URL: https://github.com/apache/pinot/pull/20182

   The table-level path of TableMetadataReader#getSegmentsMetadata passed the 
server -> endpoint map from getDataInstanceAdminEndpoints straight to 
CompletionServiceHelper, which expects endpoint -> server. Each response's 
server lookup returned null, and with multiRequestPerServer=false every body 
was stored under the same null key, overwriting the previous one. The call 
reported no failures, so there was no fallback, and the API returned 200 with 
only the last server's segments (roughly replication/N of the table).
   
   Pass endpoints.inverse() as the legacy per-segment path already does, and 
rename the misleading endpointToInstance variable in 
getDataInstanceAdminEndpoints to instanceToEndpoint.
   
   Add TableMetadataReaderTest covering full, partial and no replication across 
multiple fake servers.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to