xiangfu0 commented on code in PR #20184:
URL: https://github.com/apache/pinot/pull/20184#discussion_r4498934906
##########
kb/code-review-principles.md:
##########
@@ -1158,7 +1164,16 @@ condition
: falseExpression;
```
-- Trigger: Any PR adding or modifying a multiline ternary expression
+- Trigger: Any PR adding or modifying a ternary expression
+
+**C7.24 — Keep getter order consistent with field declarations**
Review Comment:
Minor: adding C7.24 and C7.25 makes the `## Summary` table stale. Section 7
now has 15 MINOR rules, not 13. The table should read `| 7. Naming & API Design
| 1 | 9 | 15 | 25 |`, and the total row should read `**32** | **83** | **54** |
**169**`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
