codecov-commenter commented on PR #20186: URL: https://github.com/apache/pinot/pull/20186#issuecomment-6700978271
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/20186?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `88.22206%` with `157 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 59.45%. Comparing base ([`8d140dc`](https://app.codecov.io/gh/apache/pinot/commit/8d140dcfba31efb69766ceb622e2f68005de5bf0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7fafee1`](https://app.codecov.io/gh/apache/pinot/commit/7fafee1adecf3bc605ff590ae792709185d62b1b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 2 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/pinot/pull/20186?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...al/aggregator/ArrayAggDistinctValueAggregator.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-segment-local%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Flocal%2Faggregator%2FArrayAggDistinctValueAggregator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9hZ2dyZWdhdG9yL0FycmF5QWdnRGlzdGluY3RWYWx1ZUFnZ3JlZ2F0b3IuamF2YQ==) | 48.10% | [27 Missing and 14 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/pinot/segment/local/utils/ObjectSerDeUtils.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-segment-local%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fsegment%2Flocal%2Futils%2FObjectSerDeUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91dGlscy9PYmplY3RTZXJEZVV0aWxzLmphdmE=) | 97.83% | [9 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../aggregation/function/funnel/SetMergeStrategy.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Ffunction%2Ffunnel%2FSetMergeStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9mdW5uZWwvU2V0TWVyZ2VTdHJhdGVneS5qYXZh) | 84.84% | [4 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...tion/function/funnel/ThetaSketchMergeStrategy.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Ffunction%2Ffunnel%2FThetaSketchMergeStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9mdW5uZWwvVGhldGFTa2V0Y2hNZXJnZVN0cmF0ZWd5LmphdmE=) | 84.78% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...tion/function/funnel/PartitionedMergeStrategy.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Ffunction%2Ffunnel%2FPartitionedMergeStrategy.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9mdW5uZWwvUGFydGl0aW9uZWRNZXJnZVN0cmF0ZWd5LmphdmE=) | 85.36% | [2 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/pinot/core/util/GroupByUtils.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Futil%2FGroupByUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0dyb3VwQnlVdGlscy5qYXZh) | 14.28% | [4 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...he/pinot/core/function/scalar/SketchFunctions.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Ffunction%2Fscalar%2FSketchFunctions.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9mdW5jdGlvbi9zY2FsYXIvU2tldGNoRnVuY3Rpb25zLmphdmE=) | 54.54% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...tion/BaseDistinctAggregateAggregationFunction.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Ffunction%2FBaseDistinctAggregateAggregationFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9CYXNlRGlzdGluY3RBZ2dyZWdhdGVBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | 81.48% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../function/DistinctCountULLAggregationFunction.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Ffunction%2FDistinctCountULLAggregationFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdENvdW50VUxMQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../aggregation/function/ModeAggregationFunction.java](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&filepath=pinot-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpinot%2Fcore%2Fquery%2Faggregation%2Ffunction%2FModeAggregationFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9Nb2RlQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | 77.27% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [30 more](https://app.codecov.io/gh/apache/pinot/pull/20186?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | > :exclamation: There is a different number of reports uploaded between BASE (8d140dc) and HEAD (7fafee1). Click for more details. > > <details><summary>HEAD has 24 uploads less than BASE</summary> > >| Flag | BASE (8d140dc) | HEAD (7fafee1) | >|------|------|------| >|unittests|2|1| >|java-25|6|1| >|temurin|6|1| >|lane-a|2|0| >|integration|4|0| >|integration1|2|0| >|lane-b|2|0| >|unittests2|1|0| >|integration2|2|0| ></details> <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #20186 +/- ## ============================================= - Coverage 70.42% 59.45% -10.98% + Complexity 1639 1 -1638 ============================================= Files 3571 2749 -822 Lines 238955 174839 -64116 Branches 38503 28954 -9549 ============================================= - Hits 168293 103956 -64337 - Misses 57868 62160 +4292 + Partials 12794 8723 -4071 ``` | [Flag](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration1](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration2](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [java-25](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.45% <88.22%> (-10.98%)` | :arrow_down: | | [lane-a](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [lane-b](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [temurin](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.45% <88.22%> (-10.98%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.45% <88.22%> (-10.97%)` | :arrow_down: | | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.45% <88.22%> (-0.07%)` | :arrow_down: | | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/20186/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/20186?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
