kishoreg commented on a change in pull request #4896: Build shaded jar for all
record readers
URL: https://github.com/apache/incubator-pinot/pull/4896#discussion_r354974911
##########
File path: pinot-record-readers/pinot-avro/pom.xml
##########
@@ -42,6 +42,33 @@
</plugin>
</plugins>
</build>
+ <profiles>
+ <profile>
+ <id>build-shaded-jar</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-shade-plugin</artifactId>
+ <version>3.2.1</version>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+
<outputDirectory>target/plugins/record-reader/avro-record-reader-package</outputDirectory>
Review comment:
can we change it to plugins/record-readers/pinot-avro or
plugins/record-readers/pinot-avro-pkg match the module name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
