manakbisht commented on code in PR #20116:
URL: https://github.com/apache/pinot/pull/20116#discussion_r4454960057
##########
pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigSerDeUtilsTest.java:
##########
@@ -376,6 +377,57 @@ public void testSerDe()
assertEquals(tunerConfigToCompare.getName(), name);
assertEquals(tunerConfigToCompare.getTunerProperties(), props);
}
+ {
+ // With hybrid table retention strategy
Review Comment:
Added the raw JSON `"DEFAULT"` case (parse → omitted on re-serialization →
equals unset config → ZNRecord round trip); verified it fails without the
setter `@JsonProperty`. Kept it inside `testSerDe()` to match the existing
per-feature block structure there — happy to extract if you feel strongly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
