BackendArchitectX commented on code in PR #19915:
URL: https://github.com/apache/pinot/pull/19915#discussion_r4540429599


##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/SegmentGroupsBuilder.java:
##########
@@ -227,7 +258,8 @@ SegmentGroups build() {
   /// Returns the instances unavailable for any old segment, keyed by the 
instances in the ideal state of the segment:
   /// the instances that are not online for routing in both the ideal state 
and the external view.
   private Map<Set<String>, Set<String>> 
computeUnavailableInstancesMap(List<InstanceStateMaps> instanceStateMapsList) {
-    Map<Set<String>, Set<String>> unavailableInstancesMap = new HashMap<>();
+    Map<Set<String>, Set<String>> unavailableInstancesMap =
+        new Object2ObjectOpenCustomHashMap<>(INSTANCE_SET_STRATEGY);

Review Comment:
   Fixed in `c4d6d01521`. Updated the map declaration to use fastutil's 
optimized implementation. All 99 targeted tests pass locally. Thanks for the 
suggestion!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to