swaminathanmanish commented on PR #20222: URL: https://github.com/apache/pinot/pull/20222#issuecomment-6815208517
@manakbisht - Let keep the fallback. This can have unintended consequences. ``` Long segment lists go in the URL, and the fallback was absorbing the failures. - The table-level request puts every segment name in the query string (generateTableMetadataServerURL → UrlBuilderUtils.generateColumnsAndSegmentsParam). - The caller can sends list of segment names per call - That is hundreds of KB of URL. Server HTTP stacks typically cap the request line at about 8 KB, so the table-level call should fail with 414/400 for any batch above roughly 100 segments. - Today that failure quietly falls back to per-segment calls. After this PR, getSegmentMetadataForBatch catches the error and logs "skipping generating tasks". This breaks the callers flow. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
