noob-se7en commented on code in PR #20223:
URL: https://github.com/apache/pinot/pull/20223#discussion_r4547817473
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -2278,6 +2278,12 @@ private void setConsumeEndTime(SegmentZKMetadata
segmentZKMetadata, long now) {
long maxConsumeTimeMillis = _streamConfig.getFlushThresholdTimeMillis();
_consumeEndTime = segmentZKMetadata.getCreationTime() +
maxConsumeTimeMillis;
+ // For pauseless tables, keep the end time from ZK while it is in the
future so that all replicas stop together.
+ // A replica that consumes past the end offset fixed at commit start can
only download the committed segment.
+ if (_consumeEndTime > now &&
PauselessConsumptionUtils.isPauselessEnabled(_tableConfig)) {
+ return;
Review Comment:
what about the other case - when consumeEnd time is in the past?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
