bxji commented on issue #4935: Fix infinite loop fetch anomaly URL: https://github.com/apache/incubator-pinot/pull/4935#issuecomment-566728859 Seems fine to me... only nit is that we are using something like `Set<Long> visitedIds = new HashSet<>(); visitedIds.add(bean.getId());` in multiple places and we could avoid some duplication by making a util function to initialize and add self id to list of visited anomalies.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
